multi: mention integer overflow risk if using > 500 million sockets

Reported-by: ovidiu-benea@users.noreply.github.com
Closes #1675
Closes #1683

diff --git a/lib/multi.c b/lib/multi.c
index 5753f58f7461b1221afc49f6b2d9641ad1a26628..217849c5abe77fc152c05704c288b1a9fa9d1a9f 100644 (file)
--- a/lib/multi.c
+++ b/lib/multi.c
@@ -1022,6 +1022,10 @@ CURLMcode curl_multi_wait(struct Curl_multi *multi,
 
   if(nfds) {
     if(nfds > NUM_POLLS_ON_STACK) {
+      /* 'nfds' is a 32 bit value and 'struct pollfd' is typically 8 bytes
+         big, so at 2^29 sockets this value might wrap. When a process gets
+         the capability to actually handle over 500 million sockets this
+         calculation needs a integer overflow check. */
       ufds = malloc(nfds * sizeof(struct pollfd));
       if(!ufds)
         return CURLM_OUT_OF_MEMORY;