t9117: prefer test_path_* helper functions

test -(e|d) does not provide a nice error message when we hit test
failures, so use test_path_exists, test_path_is_dir instead.

Signed-off-by: shejialuo <shejialuo@gmail.com>
Acked-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/t/t9117-git-svn-init-clone.sh b/t/t9117-git-svn-init-clone.sh
index 62de819a44e40c8fae821789e1d11753054a2258..3b038c338f2154e4470d3f472a448d5881adf54d 100755 (executable)
--- a/t/t9117-git-svn-init-clone.sh
+++ b/t/t9117-git-svn-init-clone.sh
@@ -17,32 +17,32 @@ test_expect_success 'setup svnrepo' '
 test_expect_success 'basic clone' '
        test ! -d trunk &&
        git svn clone "$svnrepo"/project/trunk &&
-       test -d trunk/.git/svn &&
-       test -e trunk/foo &&
+       test_path_is_dir trunk/.git/svn &&
+       test_path_exists trunk/foo &&
        rm -rf trunk
        '
 
 test_expect_success 'clone to target directory' '
        test ! -d target &&
        git svn clone "$svnrepo"/project/trunk target &&
-       test -d target/.git/svn &&
-       test -e target/foo &&
+       test_path_is_dir target/.git/svn &&
+       test_path_exists target/foo &&
        rm -rf target
        '
 
 test_expect_success 'clone with --stdlayout' '
        test ! -d project &&
        git svn clone -s "$svnrepo"/project &&
-       test -d project/.git/svn &&
-       test -e project/foo &&
+       test_path_is_dir project/.git/svn &&
+       test_path_exists project/foo &&
        rm -rf project
        '
 
 test_expect_success 'clone to target directory with --stdlayout' '
        test ! -d target &&
        git svn clone -s "$svnrepo"/project target &&
-       test -d target/.git/svn &&
-       test -e target/foo &&
+       test_path_is_dir target/.git/svn &&
+       test_path_exists target/foo &&
        rm -rf target
        '