]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
pinctrl: airoha: Fix AIROHA_PINCTRL_CONFS_DRIVE_E2 in an7583_pinctrl_match_data
authorNathan Chancellor <nathan@kernel.org>
Wed, 12 Nov 2025 18:44:30 +0000 (11:44 -0700)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 18 Nov 2025 23:03:30 +0000 (00:03 +0100)
Clang warns (or errors with CONFIG_WERROR=y / W=e):

  pinctrl/mediatek/pinctrl-airoha.c:2064:41: error: variable 'an7583_pinctrl_drive_e2_conf' is not needed and will not be emitted [-Werror,-Wunneeded-internal-declaration]
   2064 | static const struct airoha_pinctrl_conf an7583_pinctrl_drive_e2_conf[] = {
        |                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

Due to a typo, an7583_pinctrl_drive_e2_conf is only used within
ARRAY_SIZE() (hence no instance of -Wunused-variable), which is
evaluated at compile time, so it will not be needed in the final object
file.

Fix the .confs assignment for AIROHA_PINCTRL_CONFS_DRIVE_E2 in
an7583_pinctrl_match_data to clear up the warning.

Closes: https://github.com/ClangBuiltLinux/linux/issues/2142
Fixes: 3ffeb17a9a27 ("pinctrl: airoha: add support for Airoha AN7583 PINs")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Acked-by: Christian Marangi <ansuelsmth@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/mediatek/pinctrl-airoha.c

index 2a5b9b6f08d9ea0e343ca1b4b32707704a5cce77..995ba6175c9504ba35a4029ce51f98003b75c33b 100644 (file)
@@ -2993,7 +2993,7 @@ static const struct airoha_pinctrl_match_data an7583_pinctrl_match_data = {
                        .num_confs = ARRAY_SIZE(an7583_pinctrl_pulldown_conf),
                },
                [AIROHA_PINCTRL_CONFS_DRIVE_E2] = {
-                       .confs = en7581_pinctrl_drive_e2_conf,
+                       .confs = an7583_pinctrl_drive_e2_conf,
                        .num_confs = ARRAY_SIZE(an7583_pinctrl_drive_e2_conf),
                },
                [AIROHA_PINCTRL_CONFS_DRIVE_E4] = {