]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
LoongArch: gas: Simplify relocations in sections without code flag
authorJinyang He <hejinyang@loongson.cn>
Mon, 22 Apr 2024 09:49:50 +0000 (17:49 +0800)
committerliuzhensong <liuzhensong@loongson.cn>
Thu, 25 Apr 2024 03:53:15 +0000 (11:53 +0800)
Gas should not emit ADD/SUB relocation pairs for label differences
if they are in the same section without code flag even relax enabled.
Because the real value is not be affected by relaxation and it can be
compute out in assembly stage. Thus, correct the `TC_FORCE_RELOCATION
_SUB_SAME` and the label differences in same section without code
flag can be resolved in fixup_segment().

gas/config/tc-loongarch.h
gas/testsuite/gas/loongarch/relax_debug_line.d [new file with mode: 0644]
gas/testsuite/gas/loongarch/relax_debug_line.s [new file with mode: 0644]

index e0d0962e5f089edbd0271e028294c9b81ade7067..e1ef42c1314ee3bb8d7290f85710d1e280987926 100644 (file)
@@ -91,9 +91,7 @@ extern bool loongarch_frag_align_code (int, int);
 #define TC_FORCE_RELOCATION_SUB_SAME(FIX, SEC) \
   (LARCH_opts.relax ?  \
     (GENERIC_FORCE_RELOCATION_SUB_SAME (FIX, SEC)      \
-      || ((SEC)->flags & SEC_CODE) != 0                \
-      || ((SEC)->flags & SEC_DEBUGGING) != 0   \
-      || TC_FORCE_RELOCATION (FIX)) \
+      || ((SEC)->flags & SEC_CODE) != 0)               \
     : (GENERIC_FORCE_RELOCATION_SUB_SAME (FIX, SEC))) \
 
 #define TC_LINKRELAX_FIXUP(seg) ((seg->flags & SEC_CODE)  \
diff --git a/gas/testsuite/gas/loongarch/relax_debug_line.d b/gas/testsuite/gas/loongarch/relax_debug_line.d
new file mode 100644 (file)
index 0000000..c17813c
--- /dev/null
@@ -0,0 +1,12 @@
+#as: --gdwarf-5
+#readelf: -r --wide
+#skip: loongarch32-*-*
+
+Relocation section '\.rela\.debug_line' at offset .* contains 5 entries:
+#...
+0+22.*R_LARCH_32[ \t]+[0-9]+.*
+0+2c.*R_LARCH_32[ \t]+[0-9]+.*
+0+36.*R_LARCH_64[ \t]+[0-9]+.*
+0+42.*R_LARCH_ADD16[ \t]+[0-9]+.*
+0+42.*R_LARCH_SUB16[ \t]+[0-9]+.*
+#pass
diff --git a/gas/testsuite/gas/loongarch/relax_debug_line.s b/gas/testsuite/gas/loongarch/relax_debug_line.s
new file mode 100644 (file)
index 0000000..d2852bb
--- /dev/null
@@ -0,0 +1,6 @@
+  .file 0 "test"
+  .text
+  .loc 0 10 0
+  nop
+
+.section .debug_line, "", @progbits