]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
4.4-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 5 Sep 2017 06:22:23 +0000 (08:22 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 5 Sep 2017 06:22:23 +0000 (08:22 +0200)
added patches:
crypto-algif_skcipher-only-call-put_page-on-referenced-and-used-pages.patch

queue-4.4/crypto-algif_skcipher-only-call-put_page-on-referenced-and-used-pages.patch [new file with mode: 0644]
queue-4.4/series

diff --git a/queue-4.4/crypto-algif_skcipher-only-call-put_page-on-referenced-and-used-pages.patch b/queue-4.4/crypto-algif_skcipher-only-call-put_page-on-referenced-and-used-pages.patch
new file mode 100644 (file)
index 0000000..5d552e7
--- /dev/null
@@ -0,0 +1,44 @@
+From 445a582738de6802669aeed9c33ca406c23c3b1f Mon Sep 17 00:00:00 2001
+From: Stephan Mueller <smueller@chronox.de>
+Date: Wed, 16 Aug 2017 11:56:24 +0200
+Subject: crypto: algif_skcipher - only call put_page on referenced and used pages
+
+From: Stephan Mueller <smueller@chronox.de>
+
+commit 445a582738de6802669aeed9c33ca406c23c3b1f upstream.
+
+For asynchronous operation, SGs are allocated without a page mapped to
+them or with a page that is not used (ref-counted). If the SGL is freed,
+the code must only call put_page for an SG if there was a page assigned
+and ref-counted in the first place.
+
+This fixes a kernel crash when using io_submit with more than one iocb
+using the sendmsg and sendpage (vmsplice/splice) interface.
+
+Signed-off-by: Stephan Mueller <smueller@chronox.de>
+Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+
+---
+ crypto/algif_skcipher.c |    9 +++++++--
+ 1 file changed, 7 insertions(+), 2 deletions(-)
+
+--- a/crypto/algif_skcipher.c
++++ b/crypto/algif_skcipher.c
+@@ -86,8 +86,13 @@ static void skcipher_free_async_sgls(str
+       }
+       sgl = sreq->tsg;
+       n = sg_nents(sgl);
+-      for_each_sg(sgl, sg, n, i)
+-              put_page(sg_page(sg));
++      for_each_sg(sgl, sg, n, i) {
++              struct page *page = sg_page(sg);
++
++              /* some SGs may not have a page mapped */
++              if (page && atomic_read(&page->_count))
++                      put_page(page);
++      }
+       kfree(sreq->tsg);
+ }
index af8c9fa295f5e24d6d2b222826935465d546ffe9..87c5631da7ea1983a211d803cf42dcc55bab5467 100644 (file)
@@ -13,3 +13,4 @@ drm-ttm-fix-accounting-error-when-fail-to-get-pages-for-pool.patch
 kvm-arm-arm64-fix-race-in-resetting-stage2-pgd.patch
 kvm-arm-arm64-force-reading-uncached-stage2-pgd.patch
 epoll-fix-race-between-ep_poll_callback-pollfree-and-ep_free-ep_remove.patch
+crypto-algif_skcipher-only-call-put_page-on-referenced-and-used-pages.patch