tests: Create symlinks using posix extensions

This way we can run the tests and more easily put them into knownfail
individually. Before this, everything went into the error category,
which was not so easy to catch in something like knownfail.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/python/samba/tests/smb2symlink.py b/python/samba/tests/smb2symlink.py
index 14f6056ac15b81f8c782369e73a4d5460d97633f..32d2f94b37e0b0b24e59b6873a6c4cfc9f76a903 100644 (file)
--- a/python/samba/tests/smb2symlink.py
+++ b/python/samba/tests/smb2symlink.py
@@ -34,10 +34,12 @@ class Smb2SymlinkTests(samba.tests.libsmb.LibsmbTests):
                 self.server_ip,
                 share,
                 self.lp,
-                self.creds)
+                self.creds,
+                force_smb1=True)
         except NTSTATUSError as e:
             if e.args[0] != ntstatus.NT_STATUS_CONNECTION_RESET:
                 raise
+        smb1.smb1_posix()
 
         share = samba.tests.env_get_var_value(
             "SMB2_SHARE", allow_missing=True)

diff --git a/selftest/knownfail.d/symlink b/selftest/knownfail.d/symlink
new file mode 100644 (file)
index 0000000..6413566
--- /dev/null
+++ b/selftest/knownfail.d/symlink
@@ -0,0 +1,4 @@
+^samba.tests.smb2symlink.samba.tests.smb2symlink.Smb2SymlinkTests.test_symlinkerror_directory
+^samba.tests.smb2symlink.samba.tests.smb2symlink.Smb2SymlinkTests.test_symlinkerror_file
+^samba.tests.smb2symlink.samba.tests.smb2symlink.Smb2SymlinkTests.test_symlinkerror_absolute_outside_share
+^samba.tests.smb2symlink.samba.tests.smb2symlink.Smb2SymlinkTests.test_symlinkerror_absolute_inshare

diff --git a/selftest/skip b/selftest/skip
index e808367c00db7e03324b4ac4a06d8f133bc39ba1..cc2fe8979e8a99bf986aa13a38a74e3cce22d41f 100644 (file)
--- a/selftest/skip
+++ b/selftest/skip
@@ -147,5 +147,4 @@ bench # don't run benchmarks in our selftest
 ^samba4.smb2.tcon.*\(ad_dc_ntvfs\)$ # Ignore ad_dc_ntvfs since this is a new test
 ^samba4.smb2.mkdir.*\(ad_dc_ntvfs\)$ # Ignore ad_dc_ntvfs since this is a new test
 ^samba.tests.reparsepoints.*
-^samba.tests.smb2symlink.*
 ^samba3.blackbox.open-eintr.*