]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/amdgpu: fix the logic to validate fpriv and root bo
authorSunil Khatri <sunil.khatri@amd.com>
Wed, 9 Jul 2025 07:16:18 +0000 (12:46 +0530)
committerChristian König <christian.koenig@amd.com>
Wed, 9 Jul 2025 08:15:30 +0000 (10:15 +0200)
Fix the smatch warning,
smatch warnings:
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:2146 amdgpu_pt_info_read()
error: we previously assumed 'fpriv' could be null (see line 2146)

"if (!fpriv && !fpriv->vm.root.bo)", It has to be an OR condition
rather than an AND which makes an NULL dereference in case fpriv is NULL.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202507090525.9rDWGhz3-lkp@intel.com/
Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
Link: https://lore.kernel.org/r/20250709071618.591866-1-sunil.khatri@amd.com
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Christian König <christian.koenig@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c

index 2353455d4aff8533854960dd8c869907f84fc61d..0e6e2e2acf5b5d73eaef65c8d81eb66b287eb84b 100644 (file)
@@ -2143,7 +2143,7 @@ static int amdgpu_pt_info_read(struct seq_file *m, void *unused)
                return -EINVAL;
 
        fpriv = file->driver_priv;
-       if (!fpriv && !fpriv->vm.root.bo)
+       if (!fpriv || !fpriv->vm.root.bo)
                return -ENODEV;
 
        root_bo = amdgpu_bo_ref(fpriv->vm.root.bo);