]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: i2c: imx335: Use %pe format specifier
authorRicardo Ribalda <ribalda@chromium.org>
Mon, 13 Oct 2025 14:14:50 +0000 (14:14 +0000)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Fri, 17 Oct 2025 09:31:15 +0000 (11:31 +0200)
The %pe format specifier is designed to print error pointers. It prints
a symbolic error name (eg. -EINVAL) and it makes the code simpler by
omitting PTR_ERR().

This patch fixes this cocci report:
./i2c/imx335.c:1013:3-10: WARNING: Consider using %pe to print PTR_ERR()

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/imx335.c

index c043df2f15fb25b3a56422092f99a1fd9a508fa9..71ed9a0d84a252ee362621c4d38001508fb86d28 100644 (file)
@@ -1009,8 +1009,8 @@ static int imx335_parse_hw_config(struct imx335 *imx335)
        imx335->reset_gpio = devm_gpiod_get_optional(imx335->dev, "reset",
                                                     GPIOD_OUT_HIGH);
        if (IS_ERR(imx335->reset_gpio)) {
-               dev_err(imx335->dev, "failed to get reset gpio %ld\n",
-                       PTR_ERR(imx335->reset_gpio));
+               dev_err(imx335->dev, "failed to get reset gpio %pe\n",
+                       imx335->reset_gpio);
                return PTR_ERR(imx335->reset_gpio);
        }