]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
PCI: dra7xx: Fix threaded IRQ request for "dra7xx-pcie-main" IRQ
authorSiddharth Vadapalli <s-vadapalli@ti.com>
Tue, 27 Aug 2024 12:24:21 +0000 (17:54 +0530)
committerKrzysztof Wilczyński <kwilczynski@kernel.org>
Fri, 13 Sep 2024 21:34:38 +0000 (21:34 +0000)
Commit da87d35a6e51 ("PCI: dra7xx: Use threaded IRQ handler for
"dra7xx-pcie-main" IRQ") switched from devm_request_irq() to
devm_request_threaded_irq() for the "dra7xx-pcie-main" interrupt.

Since the primary handler was set to NULL, the "IRQF_ONESHOT" flag
should have also been set. Fix this.

Fixes: da87d35a6e51 ("PCI: dra7xx: Use threaded IRQ handler for "dra7xx-pcie-main" IRQ")
Suggested-by: Vignesh Raghavendra <vigneshr@ti.com>
Link: https://lore.kernel.org/linux-pci/20240827122422.985547-2-s-vadapalli@ti.com
Reported-by: Udit Kumar <u-kumar1@ti.com>
Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: stable@vger.kernel.org
drivers/pci/controller/dwc/pci-dra7xx.c

index 4fe3b0cb72ec51348b2024abe98de98b76f74217..20fb50741f3dc73a0bc0834e478b4f07a5caac87 100644 (file)
@@ -850,7 +850,8 @@ static int dra7xx_pcie_probe(struct platform_device *pdev)
        dra7xx->mode = mode;
 
        ret = devm_request_threaded_irq(dev, irq, NULL, dra7xx_pcie_irq_handler,
-                              IRQF_SHARED, "dra7xx-pcie-main", dra7xx);
+                                       IRQF_SHARED | IRQF_ONESHOT,
+                                       "dra7xx-pcie-main", dra7xx);
        if (ret) {
                dev_err(dev, "failed to request irq\n");
                goto err_gpio;