]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: atomisp: do not free kmalloc memory by vfree
authorJiri Slaby <jslaby@suse.cz>
Fri, 19 Feb 2021 10:12:16 +0000 (11:12 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 23 Mar 2021 15:47:50 +0000 (16:47 +0100)
fw_minibuffer[i].buffer is allocated by kmalloc in sh_css_load_blob_info
and by vmalloc in setup_binary. So use kvfree to decide which of those
allocators to use for freeing.

Also remove the useless cast.

Link: https://lore.kernel.org/linux-media/20210219101216.28406-1-jslaby@suse.cz
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/atomisp/pci/sh_css_firmware.c

index db25e39bea886fe5ab9b1c03effcb48d7d7015c6..f4ce8ace9d509a5ddcf87f3a1ae9b803a8d82099 100644 (file)
@@ -366,7 +366,7 @@ void sh_css_unload_firmware(void)
                        if (fw_minibuffer[i].name)
                                kfree((void *)fw_minibuffer[i].name);
                        if (fw_minibuffer[i].buffer)
-                               vfree((void *)fw_minibuffer[i].buffer);
+                               kvfree(fw_minibuffer[i].buffer);
                }
                kfree(fw_minibuffer);
                fw_minibuffer = NULL;