]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/xe/devcoredump: Move exec queue snapshot to Contexts section
authorLucas De Marchi <lucas.demarchi@intel.com>
Thu, 23 Jan 2025 05:11:11 +0000 (21:11 -0800)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Mon, 3 Feb 2025 17:56:48 +0000 (12:56 -0500)
Having the exec queue snapshot inside a "GuC CT" section was always
wrong.  Commit c28fd6c358db ("drm/xe/devcoredump: Improve section
headings and add tile info") tried to fix that bug, but with that also
broke the mesa tool that parses the devcoredump, hence it was reverted
in commit a53da2fb25a3 ("drm/xe: Revert some changes that break a mesa
debug tool").

With the mesa tool also fixed, this can propagate as a fix on both
kernel and userspace side to avoid unnecessary headache for a debug
feature.

Cc: John Harrison <John.C.Harrison@Intel.com>
Cc: Julia Filipchuk <julia.filipchuk@intel.com>
Cc: José Roberto de Souza <jose.souza@intel.com>
Cc: stable@vger.kernel.org
Fixes: a53da2fb25a3 ("drm/xe: Revert some changes that break a mesa debug tool")
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250123051112.1938193-2-lucas.demarchi@intel.com
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
(cherry picked from commit a37934ea75d331fafa7fe80b6180642ba5193422)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_devcoredump.c

index 81dc7795c0651ab3726f76b38a742864095bfa2e..a7946a76777e7e757aac9a4d4253605772837183 100644 (file)
@@ -119,11 +119,7 @@ static ssize_t __xe_devcoredump_read(char *buffer, size_t count,
        drm_puts(&p, "\n**** GuC CT ****\n");
        xe_guc_ct_snapshot_print(ss->guc.ct, &p);
 
-       /*
-        * Don't add a new section header here because the mesa debug decoder
-        * tool expects the context information to be in the 'GuC CT' section.
-        */
-       /* drm_puts(&p, "\n**** Contexts ****\n"); */
+       drm_puts(&p, "\n**** Contexts ****\n");
        xe_guc_exec_queue_snapshot_print(ss->ge, &p);
 
        drm_puts(&p, "\n**** Job ****\n");