]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/xe/devcoredump: Remove IS_ERR_OR_NULL check for kzalloc
authorShuicheng Lin <shuicheng.lin@intel.com>
Thu, 20 Feb 2025 00:17:10 +0000 (00:17 +0000)
committerLucas De Marchi <lucas.demarchi@intel.com>
Mon, 24 Feb 2025 21:31:35 +0000 (13:31 -0800)
kzalloc returns a valid pointer or NULL if the allocation fails.
It never returns an error pointer. It is better to check for NULL directly.

Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>
Cc: John Harrison <John.C.Harrison@Intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250220001710.1803749-3-shuicheng.lin@intel.com
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
drivers/gpu/drm/xe/xe_devcoredump.c

index 60d15e45501739181b9f4b479411b0e21bc971cc..81b9d9bb3f57ff50001e7b3a893081f73b0840fd 100644 (file)
@@ -426,8 +426,8 @@ void xe_print_blob_ascii85(struct drm_printer *p, const char *prefix, char suffi
                drm_printf(p, "Offset not word aligned: %zu", offset);
 
        line_buff = kzalloc(DMESG_MAX_LINE_LEN, GFP_KERNEL);
-       if (IS_ERR_OR_NULL(line_buff)) {
-               drm_printf(p, "Failed to allocate line buffer: %pe", line_buff);
+       if (!line_buff) {
+               drm_printf(p, "Failed to allocate line buffer\n");
                return;
        }