]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lib-smtp: client: Fix segfault occurring in connection when SSL certificate is invalid.
authorStephan Bosch <stephan.bosch@dovecot.fi>
Fri, 19 Jan 2018 13:44:50 +0000 (14:44 +0100)
committerVille Savolainen <ville.savolainen@dovecot.fi>
Mon, 5 Feb 2018 13:07:29 +0000 (15:07 +0200)
The connection is using its own local SSL settings to determine whether an
invalid certificate is allowed. However, these local settings were not properly
initialized.

src/lib-smtp/smtp-client-connection.c

index a6da1fc5dcb50ad3fe0b80a2dc1e4d3b539c1cd8..de512c5722c4204609eef53ed44a46859d3518e9 100644 (file)
@@ -1605,7 +1605,7 @@ smtp_client_connection_create(struct smtp_client *client,
                        conn->set.rawlog_dir = p_strdup_empty(pool, set->rawlog_dir);
 
                if (set->ssl != NULL)
-                       client->set.ssl = ssl_iostream_settings_dup(pool, set->ssl);
+                       conn->set.ssl = ssl_iostream_settings_dup(pool, set->ssl);
 
                if (set->master_user != NULL && *set->master_user != '\0')
                        conn->set.master_user = p_strdup_empty(pool, set->master_user);