lib-settings: test-settings-parser - Avoid crashing on unit test failure

Also makes scan-build happy.

diff --git a/src/lib-settings/test-settings-parser.c b/src/lib-settings/test-settings-parser.c
index 2be78b9727b250f7d6a37e949026a2635335270b..74642b399cf08763dba63045cfe5dead1c474704 100644 (file)
--- a/src/lib-settings/test-settings-parser.c
+++ b/src/lib-settings/test-settings-parser.c
@@ -188,8 +188,13 @@ static void test_settings_parse_boollist_string(void)
                        pool_datastack_create(), &output, &error) == 0, i);
                test_assert_idx(array_count(&output) == str_array_length(tests[i].output), i);
                unsigned int j = 0;
-               array_foreach_elem(&output, value)
-                       test_assert_strcmp_idx(tests[i].output[j++], value, i);
+               array_foreach_elem(&output, value) {
+                       const char *next_output = NULL;
+                       if (tests[i].output != NULL &&
+                           tests[i].output[j] != NULL)
+                               next_output = tests[i].output[j++];
+                       test_assert_strcmp_idx(next_output, value, i);
+               }
        } T_END;
 
        t_array_init(&output, 8);