don't set packet->vector for non-RADIUS protocols

and most of those were wrong, too :(

diff --git a/src/listen/cron/proto_cron_crontab.c b/src/listen/cron/proto_cron_crontab.c
index 383304560360c0edc1bd93a4c2f0bf393e6439a1..575f50afcdffbc705d7edef3bebb566776ddcc4e 100644 (file)
--- a/src/listen/cron/proto_cron_crontab.c
+++ b/src/listen/cron/proto_cron_crontab.c
@@ -447,7 +447,6 @@ static int mod_decode(void const *instance, request_t *request, UNUSED uint8_t *
        if (inst->code) request->packet->code = inst->code;
        request->packet->id = fr_rand() & 0xff;
        request->reply->id = request->packet->id;
-       memset(request->packet->vector, 0, sizeof(request->packet->vector));
 
        request->packet->data = talloc_zero_array(request->packet, uint8_t, 1);
        request->packet->data_len = 1;

diff --git a/src/listen/dhcpv4/proto_dhcpv4.c b/src/listen/dhcpv4/proto_dhcpv4.c
index 861e1763dde99c222f5b5a38c112d76c93dab8e2..5ea016de3444e0c2aa271bf5906032c8e950f455 100644 (file)
--- a/src/listen/dhcpv4/proto_dhcpv4.c
+++ b/src/listen/dhcpv4/proto_dhcpv4.c
@@ -179,7 +179,6 @@ static int mod_decode(UNUSED void const *instance, request_t *request, uint8_t *
         */
        request->packet->id = fr_nbo_to_uint32(data + 4);
        request->reply->id = request->packet->id;
-       memcpy(request->packet->vector, data + 4, sizeof(request->packet->vector));
 
        request->packet->data = talloc_memdup(request->packet, data, data_len);
        request->packet->data_len = data_len;

diff --git a/src/listen/load/proto_load_step.c b/src/listen/load/proto_load_step.c
index c95080bd92993e43d56c2a0c8dae7062babcf0a8..ccadf4e068a431cd6d9d1f4ac59f39d4356c0747 100644 (file)
--- a/src/listen/load/proto_load_step.c
+++ b/src/listen/load/proto_load_step.c
@@ -272,7 +272,6 @@ static int mod_decode(void const *instance, request_t *request, UNUSED uint8_t *
        if (inst->code) request->packet->code = inst->code;
        request->packet->id = fr_rand() & 0xff;
        request->reply->id = request->packet->id;
-       memset(request->packet->vector, 0, sizeof(request->packet->vector));
 
        request->packet->data = talloc_zero_array(request->packet, uint8_t, 1);
        request->packet->data_len = 1;

diff --git a/src/listen/vmps/proto_vmps.c b/src/listen/vmps/proto_vmps.c
index 63b20e42d0606196c09f766573def782e5b3af17..93e7424fb0b72ab72e03b21073ac1242d0f820db 100644 (file)
--- a/src/listen/vmps/proto_vmps.c
+++ b/src/listen/vmps/proto_vmps.c
@@ -167,7 +167,6 @@ static int mod_decode(UNUSED void const *instance, request_t *request, uint8_t *
        request->packet->code = data[0];
        request->packet->id = data[1];
        request->reply->id = data[1];
-       memcpy(request->packet->vector, data + 4, sizeof(request->packet->vector));
 
        request->packet->data = talloc_memdup(request->packet, data, data_len);
        request->packet->data_len = data_len;