]> git.ipfire.org Git - thirdparty/glibc.git/commitdiff
csu: Avoid weak ref for __ehdr_start in static PIE
authorSzabolcs Nagy <szabolcs.nagy@arm.com>
Wed, 6 Jan 2021 14:28:02 +0000 (14:28 +0000)
committerSzabolcs Nagy <szabolcs.nagy@arm.com>
Thu, 21 Jan 2021 15:54:55 +0000 (15:54 +0000)
All linkers support __ehdr_start that support static PIE linking,
so there is no need to check for its presence via a weak reference.

This avoids a RELATIVE relocation in static PIE startup code on some
targets.

With non-PIE static linking the weak ref check is kept in case the
linker does not support __ehdr_start.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
csu/libc-start.c

index db859c3bed1685d594c0776b0cec330db39e79d6..5b9ce1d158c14883469e5315fd8a5e71fb3b080b 100644 (file)
@@ -175,8 +175,12 @@ LIBC_START_MAIN (int (*main) (int, char **, char ** MAIN_AUXVEC_DECL),
          information from auxv.  */
 
       extern const ElfW(Ehdr) __ehdr_start
+# if BUILD_PIE_DEFAULT
+       __attribute__ ((visibility ("hidden")));
+# else
        __attribute__ ((weak, visibility ("hidden")));
       if (&__ehdr_start != NULL)
+# endif
         {
           assert (__ehdr_start.e_phentsize == sizeof *GL(dl_phdr));
           GL(dl_phdr) = (const void *) &__ehdr_start + __ehdr_start.e_phoff;