xfs: lift a xfs_valid_startblock into xfs_bmapi_allocate

xfs_bmapi_convert_delalloc has a xfs_valid_startblock check on the block
allocated by xfs_bmapi_allocate.  Lift it into xfs_bmapi_allocate as
we should assert the same for xfs_bmapi_write.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>

diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
index d59fc8107d6956c89e9e5f4671cbd0f8a7d58a55..eade9689599f2367cfb8a7fa22ec7b77b4790098 100644 (file)
--- a/fs/xfs/libxfs/xfs_bmap.c
+++ b/fs/xfs/libxfs/xfs_bmap.c
@@ -4221,6 +4221,11 @@ xfs_bmapi_allocate(
        if (bma->blkno == NULLFSBLOCK)
                return -ENOSPC;
 
+       if (WARN_ON_ONCE(!xfs_valid_startblock(bma->ip, bma->blkno))) {
+               xfs_bmap_mark_sick(bma->ip, whichfork);
+               return -EFSCORRUPTED;
+       }
+
        if (bma->flags & XFS_BMAPI_ZERO) {
                error = xfs_zero_extent(bma->ip, bma->blkno, bma->length);
                if (error)
@@ -4713,12 +4718,6 @@ xfs_bmapi_convert_one_delalloc(
        if (error)
                goto out_finish;
 
-       if (WARN_ON_ONCE(!xfs_valid_startblock(ip, bma.got.br_startblock))) {
-               xfs_bmap_mark_sick(ip, whichfork);
-               error = -EFSCORRUPTED;
-               goto out_finish;
-       }
-
        XFS_STATS_ADD(mp, xs_xstrat_bytes, XFS_FSB_TO_B(mp, bma.length));
        XFS_STATS_INC(mp, xs_xstrat_quick);