t1300: don't needlessly work with `core.foo` configs

We use various made-up config keys in the "core" section for no real
reason. Change them to work in the "section" section instead and be
careful to also change "cores" to "sections". Make sure to also catch
"Core", "CoReS" and similar.

There are a few instances that actually want to work with a real "core"
config such as `core.bare` or `core.editor`. After this, it's clearer
that they work with "core" for a reason.

Reported-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Martin Ågren <martin.agren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/t/t1300-config.sh b/t/t1300-config.sh
index 1439d870d61a271a583d1058b31a23d7d4d1d406..1a4156c70434f34ef7693d60b5932d92d18845b0 100755 (executable)
--- a/t/t1300-config.sh
+++ b/t/t1300-config.sh
@@ -12,75 +12,75 @@ test_expect_success 'clear default config' '
 '
 
 cat > expect << EOF
-[core]
+[section]
        penguin = little blue
 EOF
 test_expect_success 'initial' '
-       git config core.penguin "little blue" &&
+       git config section.penguin "little blue" &&
        test_cmp expect .git/config
 '
 
 cat > expect << EOF
-[core]
+[section]
        penguin = little blue
        Movie = BadPhysics
 EOF
 test_expect_success 'mixed case' '
-       git config Core.Movie BadPhysics &&
+       git config Section.Movie BadPhysics &&
        test_cmp expect .git/config
 '
 
 cat > expect << EOF
-[core]
+[section]
        penguin = little blue
        Movie = BadPhysics
-[Cores]
+[Sections]
        WhatEver = Second
 EOF
 test_expect_success 'similar section' '
-       git config Cores.WhatEver Second &&
+       git config Sections.WhatEver Second &&
        test_cmp expect .git/config
 '
 
 cat > expect << EOF
-[core]
+[section]
        penguin = little blue
        Movie = BadPhysics
        UPPERCASE = true
-[Cores]
+[Sections]
        WhatEver = Second
 EOF
 test_expect_success 'uppercase section' '
-       git config CORE.UPPERCASE true &&
+       git config SECTION.UPPERCASE true &&
        test_cmp expect .git/config
 '
 
 test_expect_success 'replace with non-match' '
-       git config core.penguin kingpin !blue
+       git config section.penguin kingpin !blue
 '
 
 test_expect_success 'replace with non-match (actually matching)' '
-       git config core.penguin "very blue" !kingpin
+       git config section.penguin "very blue" !kingpin
 '
 
 cat > expect << EOF
-[core]
+[section]
        penguin = very blue
        Movie = BadPhysics
        UPPERCASE = true
        penguin = kingpin
-[Cores]
+[Sections]
        WhatEver = Second
 EOF
 
 test_expect_success 'non-match result' 'test_cmp expect .git/config'
 
 test_expect_success 'find mixed-case key by canonical name' '
-       test_cmp_config Second cores.whatever
+       test_cmp_config Second sections.whatever
 '
 
 test_expect_success 'find mixed-case key by non-canonical name' '
-       test_cmp_config Second CoReS.WhAtEvEr
+       test_cmp_config Second SeCtIoNs.WhAtEvEr
 '
 
 test_expect_success 'subsections are not canonicalized by git-config' '
@@ -1057,12 +1057,12 @@ test_expect_success 'git -c "key=value" support' '
        true
        EOF
        {
-               git -c core.name=value config core.name &&
+               git -c section.name=value config section.name &&
                git -c foo.CamelCase=value config foo.camelcase &&
                git -c foo.flag config --bool foo.flag
        } >actual &&
        test_cmp expect actual &&
-       test_must_fail git -c name=value config core.name
+       test_must_fail git -c name=value config section.name
 '
 
 # We just need a type-specifier here that cares about the
@@ -1107,7 +1107,7 @@ test_expect_success 'aliases can be CamelCased' '
 
 test_expect_success 'git -c does not split values on equals' '
        echo "value with = in it" >expect &&
-       git -c core.foo="value with = in it" config core.foo >actual &&
+       git -c section.foo="value with = in it" config section.foo >actual &&
        test_cmp expect actual
 '
 
@@ -1838,53 +1838,53 @@ do
 done
 
 cat >.git/config <<-\EOF &&
-[core]
+[section]
 foo = true
 number = 10
 big = 1M
 EOF
 
 test_expect_success 'identical modern --type specifiers are allowed' '
-       test_cmp_config 1048576 --type=int --type=int core.big
+       test_cmp_config 1048576 --type=int --type=int section.big
 '
 
 test_expect_success 'identical legacy --type specifiers are allowed' '
-       test_cmp_config 1048576 --int --int core.big
+       test_cmp_config 1048576 --int --int section.big
 '
 
 test_expect_success 'identical mixed --type specifiers are allowed' '
-       test_cmp_config 1048576 --int --type=int core.big
+       test_cmp_config 1048576 --int --type=int section.big
 '
 
 test_expect_success 'non-identical modern --type specifiers are not allowed' '
-       test_must_fail git config --type=int --type=bool core.big 2>error &&
+       test_must_fail git config --type=int --type=bool section.big 2>error &&
        test_i18ngrep "only one type at a time" error
 '
 
 test_expect_success 'non-identical legacy --type specifiers are not allowed' '
-       test_must_fail git config --int --bool core.big 2>error &&
+       test_must_fail git config --int --bool section.big 2>error &&
        test_i18ngrep "only one type at a time" error
 '
 
 test_expect_success 'non-identical mixed --type specifiers are not allowed' '
-       test_must_fail git config --type=int --bool core.big 2>error &&
+       test_must_fail git config --type=int --bool section.big 2>error &&
        test_i18ngrep "only one type at a time" error
 '
 
 test_expect_success '--type allows valid type specifiers' '
-       test_cmp_config true  --type=bool core.foo
+       test_cmp_config true  --type=bool section.foo
 '
 
 test_expect_success '--no-type unsets type specifiers' '
-       test_cmp_config 10 --type=bool --no-type core.number
+       test_cmp_config 10 --type=bool --no-type section.number
 '
 
 test_expect_success 'unset type specifiers may be reset to conflicting ones' '
-       test_cmp_config 1048576 --type=bool --no-type --type=int core.big
+       test_cmp_config 1048576 --type=bool --no-type --type=int section.big
 '
 
 test_expect_success '--type rejects unknown specifiers' '
-       test_must_fail git config --type=nonsense core.foo 2>error &&
+       test_must_fail git config --type=nonsense section.foo 2>error &&
        test_i18ngrep "unrecognized --type argument" error
 '