]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
wl3501_cs: Remove unnecessary NULL check
authorAlex Dewar <alex.dewar90@gmail.com>
Sat, 26 Sep 2020 17:45:58 +0000 (18:45 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jul 2023 06:37:08 +0000 (08:37 +0200)
[ Upstream commit 1d2a85382282e7c77cbde5650335c3ffc6073fa1 ]

In wl3501_detach(), link->priv is checked for a NULL value before being
passed to free_netdev(). However, it cannot be NULL at this point as it
has already been passed to other functions, so just remove the check.

Addresses-Coverity: CID 710499: Null pointer dereferences (REVERSE_INULL)
Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200926174558.9436-1-alex.dewar90@gmail.com
Stable-dep-of: 391af06a02e7 ("wifi: wl3501_cs: Fix an error handling path in wl3501_probe()")
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/wl3501_cs.c

index b66c7d4798977bc5427569574a7a3dd08549cf8f..cf67ea13dd8dcefebec0759f25c8407887b83660 100644 (file)
@@ -1437,9 +1437,7 @@ static void wl3501_detach(struct pcmcia_device *link)
        wl3501_release(link);
 
        unregister_netdev(dev);
-
-       if (link->priv)
-               free_netdev(link->priv);
+       free_netdev(dev);
 }
 
 static int wl3501_get_name(struct net_device *dev, struct iw_request_info *info,