]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
Implement ranger folder for __builtin_signbit.
authorAldy Hernandez <aldyh@redhat.com>
Wed, 31 Aug 2022 12:41:29 +0000 (14:41 +0200)
committerAldy Hernandez <aldyh@redhat.com>
Thu, 1 Sep 2022 11:19:08 +0000 (13:19 +0200)
Now that we keep track of the signbit, we can use it to fold __builtin_signbit.

I am assuming I don't have try too hard to get the actual signbit
number and 1 will do.  Especially, since we're inconsistent in trunk whether
we fold the builtin or whether we calculate it at runtime.

abulafia:~$ cat a.c
float nzero = -0.0;

main(){
    printf("0x%x\n", __builtin_signbit(-0.0));
    printf("0x%x\n", __builtin_signbit(nzero));
}
abulafia:~$ gcc a.c -w && ./a.out
0x1
0x80000000

It is amazing that we've been failing to fold something as simple as
this:

if (x > 5.0)
  num = __builtin_signbit (x);

It does the right thing now :-P.

gcc/ChangeLog:

* gimple-range-fold.cc
(fold_using_range::range_of_builtin_int_call): Add case for
CFN_BUILT_IN_SIGNBIT.

gcc/testsuite/ChangeLog:

* gcc.dg/tree-ssa/vrp-float-signbit-1.c: New test.

gcc/gimple-range-fold.cc
gcc/testsuite/gcc.dg/tree-ssa/vrp-float-signbit-1.c [new file with mode: 0644]

index b0b221063206708a85cf3edfdff67c7ab7496977..d8497fc9be709d9cdf7e27c9e53d0732e68fd29e 100644 (file)
@@ -1023,6 +1023,26 @@ fold_using_range::range_of_builtin_int_call (irange &r, gcall *call,
        break;
       }
 
+    case CFN_BUILT_IN_SIGNBIT:
+      {
+       arg = gimple_call_arg (call, 0);
+       frange tmp;
+       if (src.get_operand (tmp, arg))
+         {
+           if (tmp.get_signbit ().varying_p ())
+             return false;
+           if (tmp.get_signbit ().yes_p ())
+             {
+               tree one = build_one_cst (type);
+               r.set (one, one);
+             }
+           else
+             r.set_zero (type);
+           return true;
+         }
+       break;
+      }
+
     case CFN_BUILT_IN_TOUPPER:
       {
        arg = gimple_call_arg (call, 0);
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/vrp-float-signbit-1.c b/gcc/testsuite/gcc.dg/tree-ssa/vrp-float-signbit-1.c
new file mode 100644 (file)
index 0000000..3fa783e
--- /dev/null
@@ -0,0 +1,12 @@
+// { dg-do compile }
+// { dg-options "-O2 -fdump-tree-evrp" }
+
+int num;
+
+void func(float x)
+{
+  if (x > 5.0)
+    num = __builtin_signbit (x);
+}
+
+// { dg-final { scan-tree-dump-times "num = 0;" 1 "evrp" } }