]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
sctp: Fix fall-through warnings for Clang
authorGustavo A. R. Silva <gustavoars@kernel.org>
Fri, 20 Nov 2020 18:39:41 +0000 (12:39 -0600)
committerGustavo A. R. Silva <gustavoars@kernel.org>
Tue, 18 May 2021 01:06:33 +0000 (20:06 -0500)
In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple
of warnings by explicitly adding a break statement and replacing a
comment with a goto statement instead of letting the code fall through
to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
net/sctp/input.c

index d508f6f3dd08a33419c010d7944f9f70cacdd700..5ceaf75105bae08501570ca7a6cccec87a0178a4 100644 (file)
@@ -633,7 +633,7 @@ int sctp_v4_err(struct sk_buff *skb, __u32 info)
                break;
        case ICMP_REDIRECT:
                sctp_icmp_redirect(sk, transport, skb);
-               /* Fall through to out_unlock. */
+               goto out_unlock;
        default:
                goto out_unlock;
        }
@@ -1236,6 +1236,7 @@ static struct sctp_association *__sctp_rcv_walk_lookup(struct net *net,
                                                net, ch, laddr,
                                                sctp_hdr(skb)->source,
                                                transportp);
+                       break;
                default:
                        break;
                }