]> git.ipfire.org Git - thirdparty/bugzilla.git/commitdiff
Bug 1111043: Bug.add_comment returns the wrong comment ID
authorFrédéric Buclin <LpSolit@gmail.com>
Wed, 17 Dec 2014 19:37:55 +0000 (20:37 +0100)
committerFrédéric Buclin <LpSolit@gmail.com>
Wed, 17 Dec 2014 19:37:55 +0000 (20:37 +0100)
r=dkl a=glob

Bugzilla/WebService/Bug.pm

index de358b1e027426260659f20c04ca95d875c297f0..3d7ff380455e34ac1d6fd898fd11eaf2e1e8257a 100644 (file)
@@ -981,19 +981,10 @@ sub add_comment {
     $bug->add_comment($comment, { isprivate   => $params->{is_private},
                                   is_markdown => $params->{is_markdown},
                                   work_time   => $params->{work_time} });
-    
-    # Capture the call to bug->update (which creates the new comment) in 
-    # a transaction so we're sure to get the correct comment_id.
-    
-    my $dbh = Bugzilla->dbh;
-    $dbh->bz_start_transaction();
-    
     $bug->update();
-    
-    my $new_comment_id = $dbh->bz_last_key('longdescs', 'comment_id');
-    
-    $dbh->bz_commit_transaction();
-    
+
+    my $new_comment_id = $bug->{added_comments}[0]->id;
+
     # Send mail.
     Bugzilla::BugMail::Send($bug->bug_id, { changer => $user });