]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wifi: ath10k: use = {} to initialize bmi_target_info instead of memset
authorZhongqiu Han <zhongqiu.han@oss.qualcomm.com>
Thu, 30 Oct 2025 13:00:23 +0000 (21:00 +0800)
committerJeff Johnson <jeff.johnson@oss.qualcomm.com>
Thu, 30 Oct 2025 21:55:08 +0000 (14:55 -0700)
Initialize the bmi_target_info structure using = {} at declaration time
instead of calling memset() in each bus-specific code path. This
simplifies the code and avoids an explicit memset.

Signed-off-by: Zhongqiu Han <zhongqiu.han@oss.qualcomm.com>
Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>
Link: https://patch.msgid.link/20251030130023.1836808-3-zhongqiu.han@oss.qualcomm.com
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
drivers/net/wireless/ath/ath10k/core.c

index 670c31a52a12eea4d9b68208b2ad3c004bddac55..7c2939cbde5f05d8a5828a3e7439c329b8d7fe18 100644 (file)
@@ -3352,7 +3352,7 @@ EXPORT_SYMBOL(ath10k_core_stop);
  */
 static int ath10k_core_probe_fw(struct ath10k *ar)
 {
-       struct bmi_target_info target_info;
+       struct bmi_target_info target_info = {};
        int ret = 0;
 
        ret = ath10k_hif_power_up(ar, ATH10K_FIRMWARE_MODE_NORMAL);
@@ -3363,7 +3363,6 @@ static int ath10k_core_probe_fw(struct ath10k *ar)
 
        switch (ar->hif.bus) {
        case ATH10K_BUS_SDIO:
-               memset(&target_info, 0, sizeof(target_info));
                ret = ath10k_bmi_get_target_info_sdio(ar, &target_info);
                if (ret) {
                        ath10k_err(ar, "could not get target info (%d)\n", ret);
@@ -3375,7 +3374,6 @@ static int ath10k_core_probe_fw(struct ath10k *ar)
        case ATH10K_BUS_PCI:
        case ATH10K_BUS_AHB:
        case ATH10K_BUS_USB:
-               memset(&target_info, 0, sizeof(target_info));
                ret = ath10k_bmi_get_target_info(ar, &target_info);
                if (ret) {
                        ath10k_err(ar, "could not get target info (%d)\n", ret);
@@ -3385,7 +3383,6 @@ static int ath10k_core_probe_fw(struct ath10k *ar)
                ar->hw->wiphy->hw_version = target_info.version;
                break;
        case ATH10K_BUS_SNOC:
-               memset(&target_info, 0, sizeof(target_info));
                ret = ath10k_hif_get_target_info(ar, &target_info);
                if (ret) {
                        ath10k_err(ar, "could not get target info (%d)\n", ret);