BUG/MINOR: quic: fix return value for error in start

Fix the return value used in quic-conn start callback for error. The
caller expects a negative value in this case.

Without this patch, the quic-conn and the connection stack are not
closed despite an initialization failure error, which is an undefined
behavior and may cause a crash in the end.

diff --git a/src/xprt_quic.c b/src/xprt_quic.c
index 6ab18d87110d6fd07d294b7b175f825b3d2d7fbc..528f7c01067eafa9b1a78e512e214d84f836b100 100644 (file)
--- a/src/xprt_quic.c
+++ b/src/xprt_quic.c
@@ -5756,7 +5756,7 @@ static int qc_xprt_start(struct connection *conn, void *ctx)
        qc = conn->handle.qc;
        if (qcc_install_app_ops(qc->qcc, qc->app_ops)) {
                TRACE_PROTO("Cannot install app layer", QUIC_EV_CONN_LPKT, qc);
-               return 0;
+               return -1;
        }
 
        /* mux-quic can now be considered ready. */