]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/amdgpu: fix ACA no query result after gpu reset
authorYang Wang <kevinyang.wang@amd.com>
Fri, 17 May 2024 01:18:38 +0000 (09:18 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 17 May 2024 21:40:39 +0000 (17:40 -0400)
fix ACA no query result after gpu reset.

Signed-off-by: Yang Wang <kevinyang.wang@amd.com>
Reviewed-by: Tao Zhou <tao.zhou1@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c
drivers/gpu/drm/amd/amdgpu/amdgpu_aca.h
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

index 7260a6ce015af18b3d5f2b5ad9f5eef4d0fe74c3..01d50ad603d3876af70b0e7a18e987e8e072bb64 100644 (file)
@@ -712,13 +712,6 @@ void amdgpu_aca_fini(struct amdgpu_device *adev)
        atomic_set(&aca->ue_update_flag, 0);
 }
 
-int amdgpu_aca_reset(struct amdgpu_device *adev)
-{
-       amdgpu_aca_fini(adev);
-
-       return amdgpu_aca_init(adev);
-}
-
 void amdgpu_aca_set_smu_funcs(struct amdgpu_device *adev, const struct aca_smu_funcs *smu_funcs)
 {
        struct amdgpu_aca *aca = &adev->aca;
index ba724c2a997d3298320f94f519cc43143332e233..4327ce1ceacf7b2f0de1cea7b4e22abadf22ca03 100644 (file)
@@ -192,7 +192,6 @@ struct aca_info {
 
 int amdgpu_aca_init(struct amdgpu_device *adev);
 void amdgpu_aca_fini(struct amdgpu_device *adev);
-int amdgpu_aca_reset(struct amdgpu_device *adev);
 void amdgpu_aca_set_smu_funcs(struct amdgpu_device *adev, const struct aca_smu_funcs *smu_funcs);
 bool amdgpu_aca_is_enabled(struct amdgpu_device *adev);
 
index 51f037cc807bf6695626a5216caadc42b38ddf28..06247818635a36a326cb90b97046836a21967770 100644 (file)
@@ -3611,12 +3611,11 @@ int amdgpu_ras_late_init(struct amdgpu_device *adev)
        amdgpu_ras_event_mgr_init(adev);
 
        if (amdgpu_aca_is_enabled(adev)) {
-               if (amdgpu_in_reset(adev))
-                       r = amdgpu_aca_reset(adev);
-                else
+               if (!amdgpu_in_reset(adev)) {
                        r = amdgpu_aca_init(adev);
-               if (r)
-                       return r;
+                       if (r)
+                               return r;
+               }
 
                if (!amdgpu_sriov_vf(adev))
                        amdgpu_ras_set_aca_debug_mode(adev, false);