]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: dvb: clean up redundant break statements
authorColin Ian King <colin.king@canonical.com>
Sat, 30 Mar 2019 15:25:03 +0000 (11:25 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Mon, 22 Apr 2019 15:03:26 +0000 (11:03 -0400)
There are several places where a break statement occurs before
a following break statement; these are unnecessary and can be
removed to clean up the code a little.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/dvb-frontends/drxd_hard.c

index 0a5b15bee1d7d2095d4f8978a4f9c6247c31ce09..c597d6fc30463dd66d8e6464187dc0520d9ea530 100644 (file)
@@ -2263,61 +2263,41 @@ static int DRX_Start(struct drxd_state *state, s32 off)
                case DRX_CHANNEL_LOW:
                        transmissionParams |= SC_RA_RAM_OP_PARAM_PRIO_LO;
                        status = Write16(state, EC_SB_REG_PRIOR__A, EC_SB_REG_PRIOR_LO, 0x0000);
-                       if (status < 0)
-                               break;
                        break;
                case DRX_CHANNEL_HIGH:
                        transmissionParams |= SC_RA_RAM_OP_PARAM_PRIO_HI;
                        status = Write16(state, EC_SB_REG_PRIOR__A, EC_SB_REG_PRIOR_HI, 0x0000);
-                       if (status < 0)
-                               break;
                        break;
-
                }
 
                switch (p->code_rate_HP) {
                case FEC_1_2:
                        transmissionParams |= SC_RA_RAM_OP_PARAM_RATE_1_2;
-                       if (state->type_A) {
+                       if (state->type_A)
                                status = Write16(state, EC_VD_REG_SET_CODERATE__A, EC_VD_REG_SET_CODERATE_C1_2, 0x0000);
-                               if (status < 0)
-                                       break;
-                       }
                        break;
                default:
                        operationMode |= SC_RA_RAM_OP_AUTO_RATE__M;
                        /* fall through */
                case FEC_2_3:
                        transmissionParams |= SC_RA_RAM_OP_PARAM_RATE_2_3;
-                       if (state->type_A) {
+                       if (state->type_A)
                                status = Write16(state, EC_VD_REG_SET_CODERATE__A, EC_VD_REG_SET_CODERATE_C2_3, 0x0000);
-                               if (status < 0)
-                                       break;
-                       }
                        break;
                case FEC_3_4:
                        transmissionParams |= SC_RA_RAM_OP_PARAM_RATE_3_4;
-                       if (state->type_A) {
+                       if (state->type_A)
                                status = Write16(state, EC_VD_REG_SET_CODERATE__A, EC_VD_REG_SET_CODERATE_C3_4, 0x0000);
-                               if (status < 0)
-                                       break;
-                       }
                        break;
                case FEC_5_6:
                        transmissionParams |= SC_RA_RAM_OP_PARAM_RATE_5_6;
-                       if (state->type_A) {
+                       if (state->type_A)
                                status = Write16(state, EC_VD_REG_SET_CODERATE__A, EC_VD_REG_SET_CODERATE_C5_6, 0x0000);
-                               if (status < 0)
-                                       break;
-                       }
                        break;
                case FEC_7_8:
                        transmissionParams |= SC_RA_RAM_OP_PARAM_RATE_7_8;
-                       if (state->type_A) {
+                       if (state->type_A)
                                status = Write16(state, EC_VD_REG_SET_CODERATE__A, EC_VD_REG_SET_CODERATE_C7_8, 0x0000);
-                               if (status < 0)
-                                       break;
-                       }
                        break;
                }
                if (status < 0)