src/rrd_cgi.c: fix Coverity CID#13655 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html

diff --git a/src/rrd_cgi.c b/src/rrd_cgi.c
index 0b872aa89649de97694c1afc942c5aa6689053c3..7f6e20fc2d977dbc8d769b495b58c214a74b2317 100644 (file)
--- a/src/rrd_cgi.c
+++ b/src/rrd_cgi.c
@@ -1570,13 +1570,16 @@ s_cgi    *rrdcgiInit(
     s_cgi    *res;
     s_var   **vars;
 
+    if ((res = (s_cgi *) malloc(sizeof(s_cgi))) == NULL)
+        return NULL;
+
     vars = rrdcgiReadVariables();
 
-    if (!vars)
+    if (!vars) {
+       free(res);
         return NULL;
+    }
 
-    if ((res = (s_cgi *) malloc(sizeof(s_cgi))) == NULL)
-        return NULL;
     res->vars = vars;
 
     return res;