]> git.ipfire.org Git - people/arne_f/kernel.git/commitdiff
UBI: initialize LEB number variable
authorBrian Norris <computersforpeace@gmail.com>
Sat, 28 Feb 2015 10:23:27 +0000 (02:23 -0800)
committerJiri Slaby <jslaby@suse.cz>
Mon, 4 May 2015 09:50:08 +0000 (11:50 +0200)
commit f16db8071ce18819fbd705ddcc91c6f392fb61f8 upstream.

In some of the 'out_not_moved' error paths, lnum may be used
uninitialized. Don't ignore the warning; let's fix it.

This uninitialized variable doesn't have much visible effect in the end,
since we just schedule the PEB for erasure, and its LEB number doesn't
really matter (it just gets printed in debug messages). But let's get it
straight anyway.

Coverity CID #113449

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/mtd/ubi/wl.c

index 49e570abe58b01b07a3e78e71d0fede9fd99306a..c08254016fe8b34d495793de03ffdd589e894a00 100644 (file)
@@ -999,7 +999,7 @@ static int wear_leveling_worker(struct ubi_device *ubi, struct ubi_work *wrk,
                                int cancel)
 {
        int err, scrubbing = 0, torture = 0, protect = 0, erroneous = 0;
-       int vol_id = -1, uninitialized_var(lnum);
+       int vol_id = -1, lnum = -1;
 #ifdef CONFIG_MTD_UBI_FASTMAP
        int anchor = wrk->anchor;
 #endif