]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: rndis_wlan: Replace fake flex-array with flexible-array member
authorGustavo A. R. Silva <gustavoars@kernel.org>
Wed, 22 Mar 2023 18:26:53 +0000 (12:26 -0600)
committerKalle Valo <kvalo@kernel.org>
Fri, 31 Mar 2023 14:48:27 +0000 (17:48 +0300)
Zero-length arrays as fake flexible arrays are deprecated and we are
moving towards adopting C99 flexible-array members instead.

Address the following warning found with GCC-13 and
-fstrict-flex-array=3 enabled:
drivers/net/wireless/rndis_wlan.c:2902:23: warning: array subscript 0 is outside array bounds of ‘struct ndis_80211_auth_request[0]’ [-Warray-bounds=]

This helps with the ongoing efforts to tighten the FORTIFY_SOURCE
routines on memcpy() and help us make progress towards globally
enabling -fstrict-flex-arrays=3 [1].

Link: https://github.com/KSPP/linux/issues/21
Link: https://github.com/KSPP/linux/issues/274
Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/ZBtIbU77L9eXqa4j@work
drivers/net/wireless/legacy/rndis_wlan.c

index cc361d35a90f5dd124b863e32945268dc3978906..712038d46bdb3b3d644f5c9984997ea7ccddabc7 100644 (file)
@@ -209,7 +209,7 @@ struct ndis_80211_status_indication {
        union {
                __le32                                  media_stream_mode;
                __le32                                  radio_status;
-               struct ndis_80211_auth_request          auth_request[0];
+               DECLARE_FLEX_ARRAY(struct ndis_80211_auth_request, auth_request);
                struct ndis_80211_pmkid_cand_list       cand_list;
        } u;
 } __packed;