]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
monitor/hmp-cmds: delete redundant Error check before invoke hmp_handle_error()
authorMao Zhongyi <maozhongyi@cmss.chinamobile.com>
Wed, 3 Jun 2020 08:09:00 +0000 (16:09 +0800)
committerDr. David Alan Gilbert <dgilbert@redhat.com>
Wed, 17 Jun 2020 16:48:39 +0000 (17:48 +0100)
hmp_handle_error() does Error check internally.

Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
Message-Id: <20200603080904.997083-6-maozhongyi@cmss.chinamobile.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
monitor/hmp-cmds.c

index a704b3469ac27fbd53d6e19b3649561c19a49173..504796d6e9fba85091b047f94bedd993a73da9c6 100644 (file)
@@ -1637,9 +1637,8 @@ void hmp_object_add(Monitor *mon, const QDict *qdict)
     obj = user_creatable_add_opts(opts, &err);
     qemu_opts_del(opts);
 
-    if (err) {
-        hmp_handle_error(mon, err);
-    }
+    hmp_handle_error(mon, err);
+
     if (obj) {
         object_unref(obj);
     }