]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
tty: caif: do not use N_TTY_BUF_SIZE
authorJiri Slaby (SUSE) <jirislaby@kernel.org>
Mon, 17 Mar 2025 07:00:18 +0000 (08:00 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 20 Mar 2025 15:00:50 +0000 (08:00 -0700)
N_TTY_BUF_SIZE -- as the name suggests -- is the N_TTY's buffer size.
There is no reason to couple that to caif's tty->receive_room. Use 4096
directly -- even though, it should be some sort of "SKB_MAX_ALLOC" or
alike. But definitely not N_TTY_BUF_SIZE.

N_TTY_BUF_SIZE is private and will be moved to n_tty.c later.

Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Acked-by: Jakub Kicinski <kuba@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>
Cc: David S. Miller <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org
Link: https://lore.kernel.org/r/20250317070046.24386-4-jirislaby@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/caif/caif_serial.c

index ed3a589def6b1ccd4d94d0468243c87421cf5f5e..e7d1b9301fdef89efa2ebcef8f56fd80a3f90c5e 100644 (file)
@@ -344,7 +344,7 @@ static int ldisc_open(struct tty_struct *tty)
        ser->tty = tty_kref_get(tty);
        ser->dev = dev;
        debugfs_init(ser, tty);
-       tty->receive_room = N_TTY_BUF_SIZE;
+       tty->receive_room = 4096;
        tty->disc_data = ser;
        set_bit(TTY_DO_WRITE_WAKEUP, &tty->flags);
        rtnl_lock();