Revert "memusagestat: use local glibc when linking [BZ #18465]"

This reverts commit 42dfc13abf6fbb4c7a0215238eb636b7d374e0e0.

The position of the -Wl,-rpath-link= options on the linker command
line is not correct, so the new way of linking memusagestat does not
always work.

diff --git a/ChangeLog b/ChangeLog
index 5291a88f857dc8c46862e6d3ef02cd47ba81dcdd..077d0dae29f67cc1604286118b35f25aa5ab89af 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,10 +1,3 @@
-2019-04-24  Mike Frysinger  <vapier@gentoo.org>
-
-       [BZ #18465]
-       * malloc/Makefile (others): Add memusagestat.
-       ($(objpfx)memusagestat): Delete rule.
-       (LDLIBS-memusagestat): New variable.
-
 2019-04-09  Carlos O'Donell  <carlos@redhat.com>
            Kwok Cheung Yeung  <kcy@codesourcery.com>
 

diff --git a/NEWS b/NEWS
index 07e099b5ecac9a807703cab772981d04cb3fa195..117646df7bd375e6d6713316f52d5e9d4c0ab9f3 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -14,7 +14,6 @@ Major new features:
 The following bugs are resolved with this release:
 
   [16573] malloc: Set and reset all hooks for tracing
-  [18465] memusagestat: use local glibc when linking
   [24155] x32 memcmp can treat positive length as 0 (if sign bit in RDX is set) (CVE-2019-7309)
   [24164] Systemtap probes need to use "nr" constraint on 32-bit Arm
   [24161] __run_fork_handlers self-deadlocks in malloc/tst-mallocfork2

diff --git a/malloc/Makefile b/malloc/Makefile
index aadf602dfd78590afebf5409ff9d15b85bf1db79..ab2eed09c6dabd97b75ce0a3d66530804f758ec9 100644 (file)
--- a/malloc/Makefile
+++ b/malloc/Makefile
@@ -131,7 +131,6 @@ ifneq ($(cross-compiling),yes)
 # If the gd library is available we build the `memusagestat' program.
 ifneq ($(LIBGD),no)
 others: $(objpfx)memusage
-others += memusagestat
 install-bin = memusagestat
 install-bin-script += memusage
 generated += memusagestat memusage
@@ -155,7 +154,8 @@ cpp-srcs-left := $(memusagestat-modules)
 lib := memusagestat
 include $(patsubst %,$(..)libof-iterator.mk,$(cpp-srcs-left))
 
-LDLIBS-memusagestat = $(libgd-LDFLAGS) -lgd -lpng -lz -lm
+$(objpfx)memusagestat: $(memusagestat-modules:%=$(objpfx)%.o)
+       $(LINK.o) -o $@ $^ $(libgd-LDFLAGS) -lgd -lpng -lz -lm
 
 ifeq ($(run-built-tests),yes)
 ifeq (yes,$(build-shared))