]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
Add a missing return when transforming atomic bit test and operations
authorH.J. Lu <hjl.tools@gmail.com>
Tue, 16 Nov 2021 01:37:10 +0000 (17:37 -0800)
committerH.J. Lu <hjl.tools@gmail.com>
Tue, 16 Nov 2021 03:23:58 +0000 (19:23 -0800)
When failing to transform equivalent, but slighly different cases of
atomic bit test and operations to their canonical forms, return
immediately.

gcc/

PR middle-end/103268
* tree-ssa-ccp.c (optimize_atomic_bit_test_and): Add a missing
return.

gcc/testsuite/

PR middle-end/103268
* gcc.dg/pr103268-1.c: New test.
* gcc.dg/pr103268-2.c: Likewise.

gcc/testsuite/gcc.dg/pr103268-1.c [new file with mode: 0644]
gcc/testsuite/gcc.dg/pr103268-2.c [new file with mode: 0644]
gcc/tree-ssa-ccp.c

diff --git a/gcc/testsuite/gcc.dg/pr103268-1.c b/gcc/testsuite/gcc.dg/pr103268-1.c
new file mode 100644 (file)
index 0000000..6d583d5
--- /dev/null
@@ -0,0 +1,10 @@
+/* { dg-do compile } */
+/* { dg-options "-O2" } */
+
+extern int si;
+long
+test_types (void)
+{
+  unsigned int u2 = __atomic_fetch_xor (&si, 0, 5);
+  return u2;
+}
diff --git a/gcc/testsuite/gcc.dg/pr103268-2.c b/gcc/testsuite/gcc.dg/pr103268-2.c
new file mode 100644 (file)
index 0000000..12283bb
--- /dev/null
@@ -0,0 +1,12 @@
+/* { dg-do compile } */
+/* { dg-options "-O2" } */
+extern long pscc_a_2_3;
+extern int pscc_a_1_4;
+
+void
+pscc (void)
+{
+  pscc_a_1_4 = __sync_fetch_and_and (&pscc_a_2_3, 1);
+}
+
index 0666dc652d0f4251ad3c23e9a031f2eb082fc65f..18d57729d8a47451d56f21fb32cbd84a092f99e3 100644 (file)
@@ -3638,6 +3638,8 @@ optimize_atomic_bit_test_and (gimple_stmt_iterator *gsip,
              use_stmt = use_nop_stmt;
            }
        }
+      else
+       return;
 
       if (!bit)
        {