]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
platform/x86: yt2-1380: add CONFIG_EXTCON dependency
authorArnd Bergmann <arnd@arndb.de>
Tue, 28 May 2024 11:59:33 +0000 (13:59 +0200)
committerHans de Goede <hdegoede@redhat.com>
Mon, 3 Jun 2024 09:43:15 +0000 (11:43 +0200)
This driver uses the extcon subsystem and fails to build
when it cannot call into that subsystem:

x86_64-linux-ld: vmlinux.o: in function `yt2_1380_fc_worker':
lenovo-yoga-tab2-pro-1380-fastcharger.c:(.text+0xa9d819): undefined reference to `extcon_get_state'
x86_64-linux-ld: lenovo-yoga-tab2-pro-1380-fastcharger.c:(.text+0xa9d853): undefined reference to `extcon_get_state'
x86_64-linux-ld: vmlinux.o: in function `yt2_1380_fc_serdev_probe':
lenovo-yoga-tab2-pro-1380-fastcharger.c:(.text+0xa9da22): undefined reference to `extcon_get_extcon_dev'
x86_64-linux-ld: lenovo-yoga-tab2-pro-1380-fastcharger.c:(.text+0xa9dc0c): undefined reference to `devm_extcon_register_notifier_all'

Add a Kconfig dependency to make it it always builds correctly.

Fixes: b2ed33e8d486 ("platform/x86: Add lenovo-yoga-tab2-pro-1380-fastcharger driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20240528115940.3169455-1-arnd@kernel.org
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/Kconfig

index 1953317541eab8354d38e46282ef106313466c45..665fa9524986595b02826b3645a2f4172b5c048e 100644 (file)
@@ -136,6 +136,7 @@ config YOGABOOK
 config YT2_1380
        tristate "Lenovo Yoga Tablet 2 1380 fast charge driver"
        depends on SERIAL_DEV_BUS
+       depends on EXTCON
        depends on ACPI
        help
          Say Y here to enable support for the custom fast charging protocol