Protect MemBlob::append() against raw-space writes

There is no guarantee that the 'unused' area of MemBlob is actually
unused. For example if a read buffer was being filled into the
rawSpace() of a SBuf or MemBlob it will overlap with this empty area
until a read call updates the related size state in MemBlob/SBuf.

For these cases we must use memmove() which guarantees no buffer
corruption will take place on memory overlaps.

diff --git a/src/MemBlob.cc b/src/MemBlob.cc
index 7662c11a4e29db728a412ba2b779f8fcb95312b7..d3ee617bc620cea8eb5ec29fb26081ab70605b9d 100644 (file)
--- a/src/MemBlob.cc
+++ b/src/MemBlob.cc
@@ -139,8 +139,7 @@ MemBlob::append(const char *source, const size_type n)
     if (n > 0) { // appending zero bytes is allowed but only affects the stats
         Must(willFit(n));
         Must(source);
-        /// \note memcpy() is safe because we copy to an unused area
-        memcpy(mem + size, source, n);
+        memmove(mem + size, source, n);
         size += n;
     }
     ++Stats.append;