Close fd on fdopen fail.

Originally suggested by @rgacogne, but not included in the merge of #12374
somehow.

diff --git a/pdns/recursordist/negcache.cc b/pdns/recursordist/negcache.cc
index b52690951723648854644a10ab84247f33069236..542e99acba52ee24c83e3254a98ee0cf50a1a9a4 100644 (file)
--- a/pdns/recursordist/negcache.cc
+++ b/pdns/recursordist/negcache.cc
@@ -278,6 +278,7 @@ size_t NegCache::doDump(int fd, size_t maxCacheEntries)
   }
   auto fp = std::unique_ptr<FILE, int (*)(FILE*)>(fdopen(newfd, "w"), fclose);
   if (!fp) {
+    close(newfd);
     return 0;
   }
   fprintf(fp.get(), "; negcache dump follows\n;\n");