]> git.ipfire.org Git - thirdparty/freeswitch.git/commitdiff
[mod_curl] Fix off-by-one error in argument limit checks. 2729/head
authorAron Podrigal <aronp@guaranteedplus.com>
Wed, 15 Jan 2025 20:03:07 +0000 (14:03 -0600)
committerAron Podrigal <aronp@guaranteedplus.com>
Wed, 15 Jan 2025 20:03:07 +0000 (14:03 -0600)
refs: #2727

src/mod/applications/mod_curl/mod_curl.c

index 82b38d42a9bbd412ee677460bd682fb84b4d4df6..cae06bdb302176f861b7b456c0d2405d134a1529 100644 (file)
@@ -898,7 +898,7 @@ SWITCH_STANDARD_APP(curl_app_function)
        if ((argc = switch_separate_string(mydata, ' ', argv, (sizeof(argv) / sizeof(argv[0]))))) {
                if (argc == 0) {
                        switch_goto_status(SWITCH_STATUS_SUCCESS, usage);
-               } else if (argc >= MOD_CURL_MAX_ARGS) {
+               } else if (argc > MOD_CURL_MAX_ARGS) {
                        switch_log_printf(SWITCH_CHANNEL_SESSION_LOG(session), SWITCH_LOG_ERROR, "Max args exceeded: %d\n", MOD_CURL_MAX_ARGS);
                        switch_goto_status(SWITCH_STATUS_FALSE, done);
                }
@@ -1021,7 +1021,7 @@ SWITCH_STANDARD_API(curl_function)
        if ((argc = switch_separate_string(mydata, ' ', argv, (sizeof(argv) / sizeof(argv[0]))))) {
                if (argc < 1) {
                        switch_goto_status(SWITCH_STATUS_SUCCESS, usage);
-               } else if (argc >= MOD_CURL_MAX_ARGS) {
+               } else if (argc > MOD_CURL_MAX_ARGS) {
                        switch_log_printf(SWITCH_CHANNEL_SESSION_LOG(session), SWITCH_LOG_ERROR, "Max args exceeded: %d\n", MOD_CURL_MAX_ARGS);
                        switch_goto_status(SWITCH_STATUS_FALSE, done);
                }