lib-storage: Remove mailbox_transaction_context.nontransactional_changes

Nothing cares about them. It was only set for POP3 UIDL change with
Maildir. In theory dsync replication would want to replicate such a change,
but it doesn't actually support changing UIDLs for existing mails. Other
mailbox formats don't support it anyway.

diff --git a/src/lib-storage/index/index-transaction.c b/src/lib-storage/index/index-transaction.c
index 2aa6fbebd0e5b029a230004fb91bdcc3ee373748..f5a46c9e6e9261bcc0b43692731430c963644a96 100644 (file)
--- a/src/lib-storage/index/index-transaction.c
+++ b/src/lib-storage/index/index-transaction.c
@@ -32,8 +32,6 @@ index_transaction_index_commit(struct mail_index_transaction *index_trans,
        int ret = 0;
 
        index_pop3_uidl_update_exists_finish(t);
-       if (t->nontransactional_changes)
-               t->changes->changed = TRUE;
 
        if (t->attr_pvt_trans != NULL) {
                if (dict_transaction_commit(&t->attr_pvt_trans, &error) < 0) {

diff --git a/src/lib-storage/index/maildir/maildir-mail.c b/src/lib-storage/index/maildir/maildir-mail.c
index 981299d45c361701a271fc080c8606c1fe31d62f..21688b89afa447486055a40802ddc1f614c69e91 100644 (file)
--- a/src/lib-storage/index/maildir/maildir-mail.c
+++ b/src/lib-storage/index/maildir/maildir-mail.c
@@ -629,7 +629,6 @@ static void maildir_update_pop3_uidl(struct mail *_mail, const char *uidl)
                uidl = "";
        }
 
-       _mail->transaction->nontransactional_changes = TRUE;
        maildir_uidlist_set_ext(mbox->uidlist, _mail->uid,
                                MAILDIR_UIDLIST_REC_EXT_POP3_UIDL, uidl);
 }

diff --git a/src/lib-storage/mail-storage-private.h b/src/lib-storage/mail-storage-private.h
index 5f3511fbc9ccf1b3ed98c2e4692b00729db10f25..d08959970f025d21e33eca1e24595336979a2e69 100644 (file)
--- a/src/lib-storage/mail-storage-private.h
+++ b/src/lib-storage/mail-storage-private.h
@@ -623,8 +623,6 @@ struct mailbox_transaction_context {
        struct mailbox_transaction_stats stats;
        /* Set to TRUE to update stats_* fields */
        bool stats_track:1;
-       /* We've done some non-transactional (e.g. dovecot-uidlist updates) */
-       bool nontransactional_changes:1;
 };
 
 union mail_search_module_context {