]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
usb: dwc3: imx8mp: fix device leak at unbind
authorJohan Hovold <johan@kernel.org>
Thu, 24 Jul 2025 09:19:06 +0000 (11:19 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Jul 2025 08:50:43 +0000 (10:50 +0200)
Make sure to drop the reference to the dwc3 device taken by
of_find_device_by_node() on probe errors and on driver unbind.

Fixes: 6dd2565989b4 ("usb: dwc3: add imx8mp dwc3 glue layer driver")
Cc: stable@vger.kernel.org # 5.12
Cc: Li Jun <jun.li@nxp.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20250724091910.21092-2-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc3/dwc3-imx8mp.c

index 3edc5aca76f97b6509a0c298a4b67e306d09fba3..bce6af82f54c24423c1e1fcc46913c8456b6f035 100644 (file)
@@ -244,7 +244,7 @@ static int dwc3_imx8mp_probe(struct platform_device *pdev)
                                        IRQF_ONESHOT, dev_name(dev), dwc3_imx);
        if (err) {
                dev_err(dev, "failed to request IRQ #%d --> %d\n", irq, err);
-               goto depopulate;
+               goto put_dwc3;
        }
 
        device_set_wakeup_capable(dev, true);
@@ -252,6 +252,8 @@ static int dwc3_imx8mp_probe(struct platform_device *pdev)
 
        return 0;
 
+put_dwc3:
+       put_device(&dwc3_imx->dwc3->dev);
 depopulate:
        of_platform_depopulate(dev);
 remove_swnode:
@@ -265,8 +267,11 @@ disable_rpm:
 
 static void dwc3_imx8mp_remove(struct platform_device *pdev)
 {
+       struct dwc3_imx8mp *dwc3_imx = platform_get_drvdata(pdev);
        struct device *dev = &pdev->dev;
 
+       put_device(&dwc3_imx->dwc3->dev);
+
        pm_runtime_get_sync(dev);
        of_platform_depopulate(dev);
        device_remove_software_node(dev);