]> git.ipfire.org Git - thirdparty/git.git/commitdiff
Merge branch 'disallow-control-characters-in-credential-urls-by-default'
authorJohannes Schindelin <johannes.schindelin@gmx.de>
Tue, 29 Oct 2024 22:52:11 +0000 (23:52 +0100)
committerJohannes Schindelin <johannes.schindelin@gmx.de>
Tue, 26 Nov 2024 21:14:45 +0000 (22:14 +0100)
This addresses two vulnerabilities:

- CVE-2024-50349:

Printing unsanitized URLs when asking for credentials made the
user susceptible to crafted URLs (e.g. in recursive clones) that
mislead the user into typing in passwords for trusted sites that
would then be sent to untrusted sites instead.

- CVE-2024-52006

Git may pass on Carriage Returns via the credential protocol to
credential helpers which use line-reading functions that
interpret said Carriage Returns as line endings, even though Git
did not intend that.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Trivial merge