]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
s390/pci: Mark all VFs as not implementing PCI_COMMAND_MEMORY
authorMatthew Rosato <mjrosato@linux.ibm.com>
Thu, 10 Sep 2020 14:59:56 +0000 (10:59 -0400)
committerAlex Williamson <alex.williamson@redhat.com>
Tue, 22 Sep 2020 16:52:00 +0000 (10:52 -0600)
For s390 we can have VFs that are passed-through without the associated
PF. Firmware provides an emulation layer to allow these devices to
operate independently, but is missing emulation of the Memory Space
Enable bit.  For these as well as linked VFs, set no_command_memory
which specifies these devices do not implement PCI_COMMAND_MEMORY.

Fixes: abafbc551fdd ("vfio-pci: Invalidate mmaps and block MMIO access on disabled memory")
Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
Reviewed-by: Niklas Schnelle <schnelle@linux.ibm.com>
Reviewed-by: Pierre Morel <pmorel@linux.ibm.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
arch/s390/pci/pci_bus.c

index 5967f30141563705e66067efc87c6d452e9b5fb3..c93486a9989bc33b713987a057640aedeaa40482 100644 (file)
@@ -197,9 +197,10 @@ void pcibios_bus_add_device(struct pci_dev *pdev)
         * With pdev->no_vf_scan the common PCI probing code does not
         * perform PF/VF linking.
         */
-       if (zdev->vfn)
+       if (zdev->vfn) {
                zpci_bus_setup_virtfn(zdev->zbus, pdev, zdev->vfn);
-
+               pdev->no_command_memory = 1;
+       }
 }
 
 static int zpci_bus_add_device(struct zpci_bus *zbus, struct zpci_dev *zdev)