]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/amdgpu/gfx9.4.3: fix kiq locking in KCQ reset
authorAlex Deucher <alexander.deucher@amd.com>
Mon, 7 Jul 2025 13:42:23 +0000 (09:42 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 15 Jul 2025 18:07:23 +0000 (14:07 -0400)
The ring test needs to be inside the lock.

Fixes: 4c953e53cc34 ("drm/amdgpu/gfx_9.4.3: wait for reset done before remap")
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: Jiadong Zhu <Jiadong.Zhu@amd.com>
drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c

index daed0f187bda5b252c0a350ba75e28ae8eb3da81..5f92975cc3058197d04c008cb7c31a5c9166fcc1 100644 (file)
@@ -3615,9 +3615,8 @@ pipe_reset:
        }
        kiq->pmf->kiq_map_queues(kiq_ring, ring);
        amdgpu_ring_commit(kiq_ring);
-       spin_unlock_irqrestore(&kiq->ring_lock, flags);
-
        r = amdgpu_ring_test_ring(kiq_ring);
+       spin_unlock_irqrestore(&kiq->ring_lock, flags);
        if (r) {
                dev_err(adev->dev, "fail to remap queue\n");
                return r;