]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
kunit: tool: Use qboot on QEMU x86_64
authorBrendan Jackman <jackmanb@google.com>
Fri, 24 Jan 2025 11:01:42 +0000 (11:01 +0000)
committerShuah Khan <skhan@linuxfoundation.org>
Sun, 16 Feb 2025 02:06:41 +0000 (19:06 -0700)
As noted in [0], SeaBIOS (QEMU default) makes a mess of the terminal,
qboot does not.

It turns out this is actually useful with kunit.py, since the user is
exposed to this issue if they set --raw_output=all.

qboot is also faster than SeaBIOS, but it's is marginal for this
usecase.

[0] https://lore.kernel.org/all/CA+i-1C0wYb-gZ8Mwh3WSVpbk-LF-Uo+njVbASJPe1WXDURoV7A@mail.gmail.com/

Both SeaBIOS and qboot are x86-specific.

Link: https://lore.kernel.org/r/20250124-kunit-qboot-v1-1-815e4d4c6f7c@google.com
Signed-off-by: Brendan Jackman <jackmanb@google.com>
Reviewed-by: David Gow <davidgow@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
tools/testing/kunit/qemu_configs/x86_64.py

index dc794907686304b325dbe180149169dd79bcd44f..4a6bf4e048f5b05c889e3b9b03046f14cc9b0bcc 100644 (file)
@@ -7,4 +7,6 @@ CONFIG_SERIAL_8250_CONSOLE=y''',
                           qemu_arch='x86_64',
                           kernel_path='arch/x86/boot/bzImage',
                           kernel_command_line='console=ttyS0',
-                          extra_qemu_params=[])
+                          # qboot is faster than SeaBIOS and doesn't mess up
+                          # the terminal.
+                          extra_qemu_params=['-bios', 'qboot.rom'])