overlapped_io_init() has a "bool tuntap_buffer" argument which is only
passed onwards to alloc_buf_sock_tun(), which does nothing with it.
Remove from both functions.
v2:
move alloc_buf_sock_tun() to win32.c
v3:
leave alloc_buf_sock_tun() where it is, and fix non-WIN32 call from
socket.c
Signed-off-by: Gert Doering <gert@greenie.muc.de>
Acked-by: Arne Schwabe <arne@rfc2549.org>
Message-Id: <
20230130161730.110021-1-gert@greenie.muc.de>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26099.h
tml
Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit
bdc842d72e92995261bac3579120c94f93e4064a)
Acked-by: Arne Schwabe <arne@rfc2549.org>
Message-Id: <
20230201141518.119157-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26122.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
/* allocate a buffer for socket or tun layer */
void
alloc_buf_sock_tun(struct buffer *buf,
- const struct frame *frame,
- const bool tuntap_buffer)
+ const struct frame *frame)
{
/* allocate buffer for overlapped I/O */
*buf = alloc_buf(BUF_SIZE(frame));
* allocate a buffer for socket or tun layer
*/
void alloc_buf_sock_tun(struct buffer *buf,
- const struct frame *frame,
- const bool tuntap_buffer);
+ const struct frame *frame);
/*
* EXTENDED_SOCKET_ERROR_CAPABILITY functions -- print extra error info
socket_frame_init(const struct frame *frame, struct link_socket *sock)
{
#ifdef _WIN32
- overlapped_io_init(&sock->reads, frame, FALSE, false);
- overlapped_io_init(&sock->writes, frame, TRUE, false);
+ overlapped_io_init(&sock->reads, frame, FALSE);
+ overlapped_io_init(&sock->writes, frame, TRUE);
sock->rw_handle.read = sock->reads.overlapped.hEvent;
sock->rw_handle.write = sock->writes.overlapped.hEvent;
#endif
sock->sockflags,
sock->info.proto);
#else
- alloc_buf_sock_tun(&sock->stream_buf_data,
- frame,
- false);
+ alloc_buf_sock_tun(&sock->stream_buf_data, frame);
stream_buf_init(&sock->stream_buf,
&sock->stream_buf_data,
return;
}
- overlapped_io_init(&tt->reads, frame, FALSE, true);
- overlapped_io_init(&tt->writes, frame, TRUE, true);
+ overlapped_io_init(&tt->reads, frame, FALSE);
+ overlapped_io_init(&tt->writes, frame, TRUE);
tt->adapter_index = TUN_ADAPTER_INDEX_INVALID;
if (tt->windows_driver == WINDOWS_DRIVER_WINTUN)
void
overlapped_io_init(struct overlapped_io *o,
const struct frame *frame,
- BOOL event_state,
- bool tuntap_buffer) /* if true: tuntap buffer, if false: socket buffer */
+ BOOL event_state)
{
CLEAR(*o);
}
/* allocate buffer for overlapped I/O */
- alloc_buf_sock_tun(&o->buf_init, frame, tuntap_buffer);
+ alloc_buf_sock_tun(&o->buf_init, frame);
}
void
void overlapped_io_init(struct overlapped_io *o,
const struct frame *frame,
- BOOL event_state,
- bool tuntap_buffer);
+ BOOL event_state);
void overlapped_io_close(struct overlapped_io *o);