]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
scsi: ufs: core: Convert a comment into an explicit check
authorBart Van Assche <bvanassche@acm.org>
Wed, 16 Oct 2024 20:12:01 +0000 (13:12 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 25 Oct 2024 19:30:21 +0000 (15:30 -0400)
The comment /* UFSHCD_QUIRK_REINIT_AFTER_MAX_GEAR_SWITCH is set */ is
only correct if ufshcd_device_init() is only called by
ufshcd_probe_hba().  Convert the comment into an explicit check. This
patch prepares for moving the ufshcd_device_init() calls.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20241016201249.2256266-6-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/ufs/core/ufshcd.c

index 67ee6fba6f2a7bafd1045d893170724ce7df9189..2ed1e5391152db8fea0ee73984bef31accd21b08 100644 (file)
@@ -8805,8 +8805,9 @@ static int ufshcd_device_init(struct ufs_hba *hba, bool init_dev_params)
                                return ret;
                        }
                        hba->scsi_host_added = true;
-               } else if (is_mcq_supported(hba)) {
-                       /* UFSHCD_QUIRK_REINIT_AFTER_MAX_GEAR_SWITCH is set */
+               } else if (is_mcq_supported(hba) &&
+                          hba->quirks &
+                                  UFSHCD_QUIRK_REINIT_AFTER_MAX_GEAR_SWITCH) {
                        ufshcd_config_mcq(hba);
                        ufshcd_mcq_enable(hba);
                }