]> git.ipfire.org Git - thirdparty/postgresql.git/commitdiff
Fix 1-byte buffer overrun when OID exceeds 1 billion. This probably can't
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 22 Nov 2006 21:13:16 +0000 (21:13 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 22 Nov 2006 21:13:16 +0000 (21:13 +0000)
cause any serious harm in normal cases, but if you have gcc buffer overrun
checking turned on, that will notice.  Found by Jack Orenstein.  Problem
was already fixed in CVS HEAD.

src/bin/psql/common.c

index 55af65a3ae1cd2c3bad10b21981f7491b1ae61d6..64eac98a616ba4cb3c48abcd96b4a59d4e073a69 100644 (file)
@@ -3,7 +3,7 @@
  *
  * Copyright 2000 by PostgreSQL Global Development Group
  *
- * $Header: /cvsroot/pgsql/src/bin/psql/common.c,v 1.51 2002/10/29 19:35:33 momjian Exp $
+ * $Header: /cvsroot/pgsql/src/bin/psql/common.c,v 1.51.2.1 2006/11/22 21:13:16 tgl Exp $
  */
 #include "postgres_fe.h"
 #include "common.h"
@@ -439,7 +439,7 @@ SendQuery(const char *query)
                                break;
                        case PGRES_COMMAND_OK:
                                {
-                                       char            buf[10];
+                                       char            buf[16];
 
                                        success = true;
                                        sprintf(buf, "%u", (unsigned int) PQoidValue(results));