ovl: remove upper umask handling from ovl_create_upper()

This is already done by vfs_prepare_mode() when creating the upper object
by vfs_create(), vfs_mkdir() and vfs_mknod().

No regressions have been observed in xfstests run with posix acls turned
off for the upper filesystem.

Fixes: 1639a49ccdce ("fs: move S_ISGID stripping into the vfs_*() helpers")
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>

diff --git a/fs/overlayfs/dir.c b/fs/overlayfs/dir.c
index c614e923b1434a1a0c3bfccb817786acddb98c33..116f542442ddd670c3a62861ef83c44d76f0a7f9 100644 (file)
--- a/fs/overlayfs/dir.c
+++ b/fs/overlayfs/dir.c
@@ -330,9 +330,6 @@ static int ovl_create_upper(struct dentry *dentry, struct inode *inode,
        struct dentry *newdentry;
        int err;
 
-       if (!attr->hardlink && !IS_POSIXACL(udir))
-               attr->mode &= ~current_umask();
-
        inode_lock_nested(udir, I_MUTEX_PARENT);
        newdentry = ovl_create_real(ofs, udir,
                                    ovl_lookup_upper(ofs, dentry->d_name.name,