jail: Fix return code of nice function

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

diff --git a/src/pakfire/jail.c b/src/pakfire/jail.c
index c39512490af14fe46e9f2c8fd49bde2f0e6eb7f0..92c22c22d8dc2a036171e9fba73ce66622d253f9 100644 (file)
--- a/src/pakfire/jail.c
+++ b/src/pakfire/jail.c
@@ -267,10 +267,8 @@ struct pakfire_jail* pakfire_jail_unref(struct pakfire_jail* jail) {
 
 int pakfire_jail_nice(struct pakfire_jail* jail, int nice) {
        // Check if nice level is in range
-       if (nice < -19 || nice > 20) {
-               errno = EINVAL;
-               return 1;
-       }
+       if (nice < -19 || nice > 20)
+               return -EINVAL;
 
        // Store nice level
        jail->nice = nice;

diff --git a/tests/libpakfire/jail.c b/tests/libpakfire/jail.c
index 2e29670c86f24ebddc08bf4e1fbecd306973eef1..1d22abb932277d4092c7221e8dfc7e384ea4e370 100644 (file)
--- a/tests/libpakfire/jail.c
+++ b/tests/libpakfire/jail.c
@@ -176,8 +176,8 @@ static int test_nice(const struct test* t) {
        ASSERT_SUCCESS(pakfire_jail_create(&jail, t->pakfire));
 
        // Set invalid nice levels
-       ASSERT_ERRNO(pakfire_jail_nice(jail,  100), EINVAL);
-       ASSERT_ERRNO(pakfire_jail_nice(jail, -100), EINVAL);
+       ASSERT_ERROR(pakfire_jail_nice(jail,  100), EINVAL);
+       ASSERT_ERROR(pakfire_jail_nice(jail, -100), EINVAL);
 
        // Set something sane
        ASSERT_SUCCESS(pakfire_jail_nice(jail, 5));