]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
Quote the output vars
authorFred Morcos <fred.morcos@open-xchange.com>
Mon, 8 May 2023 12:24:39 +0000 (14:24 +0200)
committerFred Morcos <fred.morcos@open-xchange.com>
Tue, 9 May 2023 07:16:12 +0000 (09:16 +0200)
.github/workflows/build-and-test-all.yml

index 4946006ca26ba6e943a8bbbe22fe3e1e5dc7f2dd..3a70f76d6a83b02ce7d019ec3df49cc0ca17ec7d 100644 (file)
@@ -22,7 +22,7 @@ jobs:
       UBSAN_OPTIONS: "print_stacktrace=1:halt_on_error=1:suppressions=${{ github.workspace }}/build-scripts/UBSan.supp"
       UNIT_TESTS: yes
     outputs:
-      clang-tidy-auth-failed: ${{ steps.clang-tidy-annotations.outputs.failed }}
+      clang-tidy-failed: ${{steps.clang-tidy-annotations.outputs.failed}}
     steps:
       - uses: PowerDNS/pdns/set-ubuntu-mirror@meta
       - uses: actions/checkout@v3
@@ -95,7 +95,7 @@ jobs:
       run:
         working-directory: ./pdns/recursordist/
     outputs:
-      clang-tidy-recursor-failed: ${{ steps.clang-tidy-annotations.outputs.failed }}
+      clang-tidy-failed: ${{ steps.clang-tidy-annotations.outputs.failed }}
     steps:
       - uses: PowerDNS/pdns/set-ubuntu-mirror@meta
       - uses: actions/checkout@v3
@@ -169,7 +169,7 @@ jobs:
       run:
         working-directory: ./pdns/dnsdistdist/
     outputs:
-      clang-tidy-dnsdist-failed: ${{ steps.clang-tidy-annotations.outputs.failed }}
+      clang-tidy-failed: ${{ steps.clang-tidy-annotations.outputs.failed }}
     steps:
       - uses: PowerDNS/pdns/set-ubuntu-mirror@meta
       - uses: actions/checkout@v3
@@ -537,10 +537,10 @@ jobs:
     runs-on: ubuntu-20.04
     name: Check whether clang-tidy succeeded
     steps:
-    - run: |
-        if [ ${{ needs.build-auth.outputs.clang-tidy-auth-failed }} != 0 -o ${{ needs.build-dnsdist.outputs.clang-tidy-dnsdist-failed }} != 0 -o ${{ needs.build-recursor.outputs.clang-tidy-recursor-failed }} != 0 ]; then
-          exit 1
-        fi
+      - run: |
+          if [ "${{needs.build-auth.outputs.clang-tidy-failed}}" != "0" -o "${{needs.build-dnsdist.outputs.clang-tidy-failed}}" != "0" -o "${{needs.build-recursor.outputs.clang-tidy-failed}}" != "0" ]; then
+            exit 1
+          fi
 
   collect:
     needs: