s390/debug: debug feature version 3

Change __debug_entry structure in the following way:
 - remove redundant union
 - Field containing cpuid is expanded to 16 bits. 8-bit width was not
   enough since we already support up to 512 cpus.
 - Field containing the timestamp is expanded to 60 bits. The timestamp
   itself is now stored in the absolute Unix time format in microseconds
   taking the Epoch Index into acount.
Adjust default header for debug entries by setting minimum width for cpuid
to 4 digits.

Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Mikhail Zaslonko <zaslonko@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>

diff --git a/arch/s390/include/asm/debug.h b/arch/s390/include/asm/debug.h
index 17a26261f28849e1972732fb9dd9dc2d776ad611..c1b82bcc017cf043989413c10025f5eb8e8e76ec 100644 (file)
--- a/arch/s390/include/asm/debug.h
+++ b/arch/s390/include/asm/debug.h
@@ -2,7 +2,7 @@
 /*
  *   S/390 debug facility
  *
- *    Copyright IBM Corp. 1999, 2000
+ *    Copyright IBM Corp. 1999, 2020
  */
 #ifndef DEBUG_H
 #define DEBUG_H
@@ -26,19 +26,14 @@
 #define DEBUG_DATA(entry) (char *)(entry + 1) /* data is stored behind */
                                              /* the entry information */
 
-#define __DEBUG_FEATURE_VERSION           2  /* version of debug feature */
+#define __DEBUG_FEATURE_VERSION           3  /* version of debug feature */
 
 struct __debug_entry {
-       union {
-               struct {
-                       unsigned long clock     : 52;
-                       unsigned long exception :  1;
-                       unsigned long level     :  3;
-                       unsigned long cpuid     :  8;
-               } fields;
-               unsigned long stck;
-       } id;
+       unsigned long clock     : 60;
+       unsigned long exception :  1;
+       unsigned long level     :  3;
        void *caller;
+       unsigned short cpu;
 } __packed;
 
 typedef struct __debug_entry debug_entry_t;

diff --git a/arch/s390/kernel/debug.c b/arch/s390/kernel/debug.c
index beb4b44a11d19b653bb55a7e23f412c4b315ed3e..b6619ae9a3e0cbdf24ab2de2e33929e187d436f7 100644 (file)
--- a/arch/s390/kernel/debug.c
+++ b/arch/s390/kernel/debug.c
@@ -2,7 +2,7 @@
 /*
  *   S/390 debug facility
  *
- *    Copyright IBM Corp. 1999, 2012
+ *    Copyright IBM Corp. 1999, 2020
  *
  *    Author(s): Michael Holzheu (holzheu@de.ibm.com),
  *              Holger Smolinski (Holger.Smolinski@de.ibm.com)
@@ -433,7 +433,7 @@ static int debug_format_entry(file_private_info_t *p_info)
        act_entry = (debug_entry_t *) ((char *)id_snap->areas[p_info->act_area]
                                       [p_info->act_page] + p_info->act_entry);
 
-       if (act_entry->id.stck == 0LL)
+       if (act_entry->clock == 0LL)
                goto out; /* empty entry */
        if (view->header_proc)
                len += view->header_proc(id_snap, view, p_info->act_area,
@@ -829,12 +829,17 @@ static inline debug_entry_t *get_active_entry(debug_info_t *id)
 static inline void debug_finish_entry(debug_info_t *id, debug_entry_t *active,
                                      int level, int exception)
 {
-       active->id.stck = get_tod_clock_fast() -
-               *(unsigned long long *) &tod_clock_base[1];
-       active->id.fields.cpuid = smp_processor_id();
+       unsigned char clk[STORE_CLOCK_EXT_SIZE];
+       unsigned long timestamp;
+
+       get_tod_clock_ext(clk);
+       timestamp = *(unsigned long *) &clk[0] >> 4;
+       timestamp -= TOD_UNIX_EPOCH >> 12;
+       active->clock = timestamp;
+       active->cpu = smp_processor_id();
        active->caller = __builtin_return_address(0);
-       active->id.fields.exception = exception;
-       active->id.fields.level = level;
+       active->exception = exception;
+       active->level = level;
        proceed_active_entry(id);
        if (exception)
                proceed_active_area(id);
@@ -1398,25 +1403,24 @@ static int debug_hex_ascii_format_fn(debug_info_t *id, struct debug_view *view,
 int debug_dflt_header_fn(debug_info_t *id, struct debug_view *view,
                         int area, debug_entry_t *entry, char *out_buf)
 {
-       unsigned long base, sec, usec;
+       unsigned long sec, usec;
        unsigned long caller;
        unsigned int level;
        char *except_str;
        int rc = 0;
 
-       level = entry->id.fields.level;
-       base = (*(unsigned long *) &tod_clock_base[0]) >> 4;
-       sec = (entry->id.stck >> 12) + base - (TOD_UNIX_EPOCH >> 12);
+       level = entry->level;
+       sec = entry->clock;
        usec = do_div(sec, USEC_PER_SEC);
 
-       if (entry->id.fields.exception)
+       if (entry->exception)
                except_str = "*";
        else
                except_str = "-";
        caller = (unsigned long) entry->caller;
-       rc += sprintf(out_buf, "%02i %011ld:%06lu %1u %1s %02i %pK  ",
+       rc += sprintf(out_buf, "%02i %011ld:%06lu %1u %1s %04u %pK  ",
                      area, sec, usec, level, except_str,
-                     entry->id.fields.cpuid, (void *)caller);
+                     entry->cpu, (void *)caller);
        return rc;
 }
 EXPORT_SYMBOL(debug_dflt_header_fn);